Skip to content

ci(drone): bump haskell-client-test image from haskell:8.6.5 to haskell:8.10#10422

Closed
PiDelport wants to merge 1 commit intoOpenAPITools:masterfrom
PiDelport:ci-drone-fix-haskell-client-test
Closed

ci(drone): bump haskell-client-test image from haskell:8.6.5 to haskell:8.10#10422
PiDelport wants to merge 1 commit intoOpenAPITools:masterfrom
PiDelport:ci-drone-fix-haskell-client-test

Conversation

@PiDelport
Copy link
Contributor

@PiDelport PiDelport commented Sep 18, 2021

This is needed for the update to LTS Haskell 18.10 in PR:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Sep 19, 2021

Thanks for the PR but we did it via https://github.com/OpenAPITools/openapi-generator/pull/10424/files#diff-9b4cf276d71d78427e35179eabe8f14bd969168ea6678faf01d4482603118d49R51 instead.

@PiDelport
Copy link
Contributor Author

@wing328: Cool, thanks!

@PiDelport PiDelport closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants