Skip to content

[JAVA][jersey2] import the auto generated supporting JSON class only when discriminator is needed#10557

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
beytun:bugfix/java_jersey2_JSON
Oct 12, 2021
Merged

[JAVA][jersey2] import the auto generated supporting JSON class only when discriminator is needed#10557
wing328 merged 2 commits intoOpenAPITools:masterfrom
beytun:bugfix/java_jersey2_JSON

Conversation

@beytun
Copy link
Contributor

@beytun beytun commented Oct 7, 2021

Import the auto generated supporting JSON class only when generateSupportingFiles is true and discriminator is needed.

The similar issue #8027 was fixed with PR #8554 for JAVA native client. This PR fixes the issue for JAVA jersey2 client.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

@beytun
Copy link
Contributor Author

beytun commented Oct 8, 2021

cc: @agilob @wing328

@wing328
Copy link
Member

wing328 commented Oct 12, 2021

LGTM

@wing328 wing328 merged commit 52713b2 into OpenAPITools:master Oct 12, 2021
wing328 added a commit that referenced this pull request Oct 14, 2021
…ss only when discriminator is needed (#10557)"

This reverts commit 52713b2.
@wing328
Copy link
Member

wing328 commented Oct 14, 2021

@beytun we've to revert this change via #10597 as it's breaking the build due to anyOf/oneOf also needs the JSON class.

For the error message , please refer to https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/13254/workflows/f53036aa-5cfe-4fd0-876e-f98464acd1cf/jobs/26909

wing328 added a commit that referenced this pull request Oct 14, 2021
…ss only when discriminator is needed (#10557)" (#10597)

This reverts commit 52713b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments