Add logic to handle uuid in Elm generator (0.19)#1075
Merged
Conversation
Contributor
|
Edit: are you sure this won't fail on other parts as well? Can check later. |
Member
Author
|
@trenneman yes, we need another PR to handle other types as well, e.g. boolean using |
Contributor
|
Yes that as well, thanks. But I mean if a UUID is not processed as a string it might fail in other parts of the generated Elm code as well. I am not sure. |
Member
Author
|
I've filed #1079 for tracking. |
Contributor
|
@wing328 thanks a lot for the quick fix! |
Member
Author
|
No problem. We'll include the fix and other enhancements in the 3.3.0 release scheduled next week. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
To fix the following issue reported in the chat room by @mxinden
Spec: https://github.com/prometheus/alertmanager/blob/master/api/v2/openapi.yaml
cc @trenneman