[typescript-fetch] fix circular imports being generated#10798
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Nov 22, 2021
BeryJu:typescript-fetch-fix-circular
Merged
[typescript-fetch] fix circular imports being generated#10798macjohnny merged 1 commit intoOpenAPITools:masterfrom BeryJu:typescript-fetch-fix-circular
macjohnny merged 1 commit intoOpenAPITools:masterfrom
BeryJu:typescript-fetch-fix-circular
Conversation
Contributor
you never know who's still active though :). so it's usually more reliable to copy-paste the full list. |
amakhrov
approved these changes
Nov 6, 2021
Contributor
amakhrov
left a comment
There was a problem hiding this comment.
Thanks for the fix - looks good to me.
There seems to be smth off with CI - the failure doesn't look related to the changes in the PR
macjohnny
reviewed
Nov 7, 2021
modules/openapi-generator/src/main/resources/typescript-fetch/modelOneOf.mustache
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
templates based off of #6140 and @ajaska
closes #6140
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07)
(I didn't want to mention all people at once so I just took the first three)