Better handling of different types in Elm generator#1100
Merged
Conversation
eriktim
requested changes
Sep 25, 2018
Contributor
eriktim
left a comment
eriktim
left a comment
There was a problem hiding this comment.
I can add the String.fromBool alternative
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
...les/openapi-generator/src/main/java/org/openapitools/codegen/languages/ElmClientCodegen.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@trenneman thanks for the feedback. Please feel free to submit a PR to |
Contributor
|
My fix is ready. I had to rebase on #1104, so I'll wait for that one to get merged. |
Member
Author
|
👌 |
eriktim
force-pushed
the
elm-enhance1
branch
from
cd15c45 to
b09a2e6
Compare
eriktim
approved these changes
Sep 29, 2018
Contributor
|
@wing328 I've updated the PR. Can you verify? |
Member
Author
|
👍 Let's merge this PR so that we can include the enhancement in the 3.3.0 release. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* better handling of different types in elm generator * [elm] Fix toString for special cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
To fix #1079
cc @trenneman