Skip to content

Bugfix of #11173: go-server get param typecasting if variable enum of string#11174

Closed
kellrott wants to merge 3 commits intoOpenAPITools:masterfrom
kellrott:issue/11173
Closed

Bugfix of #11173: go-server get param typecasting if variable enum of string#11174
kellrott wants to merge 3 commits intoOpenAPITools:masterfrom
kellrott:issue/11173

Conversation

@kellrott
Copy link

PR in response to #11173

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @antihax
    @grokify
    @kemokemo
    @jirikuncar
    @ph4r5h4d

@kellrott kellrott changed the title Fixing go-server get param typecasting if variable enum of string Bugfix of #11173: go-server get param typecasting if variable enum of string Dec 22, 2021
@wing328 wing328 added this to the 5.4.0 milestone Jan 18, 2022
@wing328 wing328 modified the milestones: 5.4.0, 6.0.0 Jan 31, 2022
@wing328
Copy link
Member

wing328 commented Mar 10, 2022

Can you please resolve the merge conflicts when you've time?

@wing328 wing328 modified the milestones: 6.0.0, 6.0.1 May 26, 2022
@wing328 wing328 modified the milestones: 6.0.1, 6.1.0 Jul 5, 2022
@wing328 wing328 modified the milestones: 6.1.0, 6.1.1 Sep 11, 2022
@wing328 wing328 modified the milestones: 6.1.1, 6.2.1 Sep 24, 2022
@wing328 wing328 modified the milestones: 6.2.1, 6.3.0 Nov 1, 2022
@Wooulf
Copy link

Wooulf commented Nov 23, 2022

Will we have this fix in the next version?

@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@skando-sony
Copy link

I crave for this feature. Will this be fixed soon?

@wing328 wing328 modified the milestones: 6.4.0, 6.5.0 Feb 19, 2023
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@lwj5
Copy link
Contributor

lwj5 commented Jun 7, 2023

I'll take a look at this and see if the changes apply to the current updates, and hopefully we can get it in 7.0.0

@lwj5
Copy link
Contributor

lwj5 commented Jun 30, 2023

@kellrott will you be able to update the PR. There has been massive changes in the way we parse objects.

If you do not have the time, let me know. I can open another PR to fix it

@wing328 wing328 modified the milestones: 7.0.0, 7.1.0, 7.0.1 Aug 25, 2023
@wing328 wing328 modified the milestones: 7.0.1, 7.1.0 Sep 20, 2023
@icubbon
Copy link
Contributor

icubbon commented Oct 19, 2023

I believe this is resolved with #16781 which has been merged.

@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328 wing328 modified the milestones: 7.3.0, 7.4.0 Feb 8, 2024
@wing328 wing328 closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants