Skip to content

[DefaultCodegen] GetReferenceHeader for both calls of headerToCodegenParameter#11756

Merged
spacether merged 2 commits intoOpenAPITools:masterfrom
Laurens-W:fix_reference_response_header
Mar 2, 2022
Merged

[DefaultCodegen] GetReferenceHeader for both calls of headerToCodegenParameter#11756
spacether merged 2 commits intoOpenAPITools:masterfrom
Laurens-W:fix_reference_response_header

Conversation

@Laurens-W
Copy link

@Laurens-W Laurens-W commented Mar 1, 2022

In #11046 a bug was introduced regarding the fetching of reference headers.
As ModelUtils.getReferencedHeader wasn't called in all cases before headerToCodegenParameter was.
So now it's called inside headerToCodegenParameter as the first thing after null checking the header.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Possibly solves #11058
Also might relate to #11061

@Laurens-W
Copy link
Author

@spacether Since you made the initial feature, can I ask you to review this?

@Laurens-W Laurens-W changed the title GetReferenceHeader for both calls of headerToCodegenParameter [DefaultCodegen] GetReferenceHeader for both calls of headerToCodegenParameter Mar 1, 2022
@Laurens-W
Copy link
Author

@spacether I've updated the PR

@spacether spacether added this to the 6.0.0 milestone Mar 2, 2022
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. This looks great!

@spacether spacether merged commit 5ad9f18 into OpenAPITools:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants