[DefaultCodegen] GetReferenceHeader for both calls of headerToCodegenParameter#11756
Merged
spacether merged 2 commits intoOpenAPITools:masterfrom Mar 2, 2022
Merged
Conversation
Author
|
@spacether Since you made the initial feature, can I ask you to review this? |
spacether
reviewed
Mar 2, 2022
modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
Outdated
Show resolved
Hide resolved
Author
|
@spacether I've updated the PR |
spacether
approved these changes
Mar 2, 2022
Contributor
spacether
left a comment
There was a problem hiding this comment.
Thank you for your PR. This looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11046 a bug was introduced regarding the fetching of reference headers.
As ModelUtils.getReferencedHeader wasn't called in all cases before headerToCodegenParameter was.
So now it's called inside headerToCodegenParameter as the first thing after null checking the header.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xPossibly solves #11058
Also might relate to #11061