Skip to content

[Java] remove samples & replace them with file asserts#11773

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
borsch:replace-samples-with-files-asserts
Mar 3, 2022
Merged

[Java] remove samples & replace them with file asserts#11773
wing328 merged 1 commit intoOpenAPITools:masterfrom
borsch:replace-samples-with-files-asserts

Conversation

@borsch
Copy link
Member

@borsch borsch commented Mar 2, 2022

Remove samples that were added within this PR #8577
Samples now are replaced with file content asserts

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch borsch requested a review from jimschubert as a code owner March 2, 2022 15:31
@wing328 wing328 added this to the 6.0.0 milestone Mar 3, 2022
@wing328 wing328 merged commit 3656ec5 into OpenAPITools:master Mar 3, 2022
@borsch borsch deleted the replace-samples-with-files-asserts branch March 4, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments