Skip to content

[java][client] Unhandled default enum case#12344

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
robbertvanwaveren:feature/fix-11886-java-default-enum-case
May 26, 2022
Merged

[java][client] Unhandled default enum case#12344
wing328 merged 1 commit intoOpenAPITools:masterfrom
robbertvanwaveren:feature/fix-11886-java-default-enum-case

Conversation

@robbertvanwaveren
Copy link
Copy Markdown
Contributor

@robbertvanwaveren robbertvanwaveren commented May 11, 2022

Fixes the issue #11886

Basically the suggested fix is applied in this branch which succesfully handles the enumUnknownDefaultCase=true option for the Java generator during the deserialization process.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@robbertvanwaveren
Copy link
Copy Markdown
Contributor Author

robbertvanwaveren commented May 11, 2022

As suggested in PR template, mentioning Java tech members @bbdouglas @Zomzog @lwlee2608

@robbertvanwaveren
Copy link
Copy Markdown
Contributor Author

@lukoyanov @cbornet @jeff9finger @karismann

Could this be reviewed/merged?

@wing328 wing328 modified the milestones: 6.0.0, 6.0.1 May 26, 2022
@wing328 wing328 merged commit b6ef789 into OpenAPITools:master May 26, 2022
@wing328 wing328 changed the title fix #11886 unhandled default enum case [java][client] Unhandled default enum case May 26, 2022
@janisz
Copy link
Copy Markdown
Contributor

janisz commented Jun 15, 2022

Can we backport it to 5.4.x branch? It's mentioned in the readme for java for that release but it's not implemented

@nevvermind
Copy link
Copy Markdown

What's the process of backporting features in this project? I'd also like to port this to 5.3.x, but I don't think such a maintenance branch exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants