Skip to content

Comments

Remove form model filters#13566

Open
neclimdul wants to merge 1 commit intoOpenAPITools:masterfrom
neclimdul:remove-form-encode-model-filters
Open

Remove form model filters#13566
neclimdul wants to merge 1 commit intoOpenAPITools:masterfrom
neclimdul:remove-form-encode-model-filters

Conversation

@neclimdul
Copy link
Contributor

@neclimdul neclimdul commented Oct 1, 2022

Remove form parameter schema filtering because some API's actually use this and are broken.

Fixes #6568

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Remove form parameter schema filtering because some API's actually use this and are broken.

Fixes OpenAPITools#6568
@neclimdul
Copy link
Contributor Author

I couldn't get the mvn commands to run cleanly in any branch, seeing what CI says.

Current state:

  1. I expect this could use some tests around the use case in the related issue but I don't remember how to do that.
  2. I left the method even though it isn't used. I don't know what the deprecation/removal policy would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Problems with model parameters and form-urlencode

1 participant