Skip to content

Add top level x-group-parameters support#1405

Merged
wing328 merged 2 commits intomasterfrom
top-level-group-parameter
Nov 12, 2018
Merged

Add top level x-group-parameters support#1405
wing328 merged 2 commits intomasterfrom
top-level-group-parameter

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Nov 9, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

If a top-level x-group-parameters is specified, it will be applied to all operations (that do not have x-group-parameter specified).

Currently, it only works with OpenAPI spec (OAS) v3 as there seems to be a bug with Swagger Parser not recognizing top-level vendor extensions in OAS v2

cc @OpenAPITools/generator-core-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant