Skip to content

Minor improvements to Gradle plugin#14097

Merged
wing328 merged 3 commits intomasterfrom
improve_13659
Nov 23, 2022
Merged

Minor improvements to Gradle plugin#14097
wing328 merged 3 commits intomasterfrom
improve_13659

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Nov 23, 2022

  • display a message about output directory being cleaned up
  • update the test with better wording

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 requested a review from jimschubert as a code owner November 23, 2022 03:40
@wing328 wing328 added this to the 6.3.0 milestone Nov 23, 2022
@wing328 wing328 changed the title Minor improvements to Gradle plugin, test Minor improvements to Gradle plugin Nov 23, 2022
@wing328 wing328 merged commit 743d2cd into master Nov 23, 2022
@wing328 wing328 deleted the improve_13659 branch November 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants