[csharp-netcore] Fixes issue with enum discriminators#14533
Open
krzlabrdx wants to merge 1 commit intoOpenAPITools:masterfrom
Open
[csharp-netcore] Fixes issue with enum discriminators#14533krzlabrdx wants to merge 1 commit intoOpenAPITools:masterfrom
krzlabrdx wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with csharp code generator:
enumtype is used as discriminator property autogenerated constructors of derived types use string representation of discriminators rather concrete enum value.JsonSubtypesconverter with CLR property name discriminator value rather JSON property name.Sample Schema
Generated Types (simplified)
@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti