Skip to content

[Swift4] Support both OpenAPI "date-time" variants (Fix for 699)#1454

Closed
aplikianer wants to merge 2 commits intoOpenAPITools:masterfrom
aplikianer:fix-swift4-699
Closed

[Swift4] Support both OpenAPI "date-time" variants (Fix for 699)#1454
aplikianer wants to merge 2 commits intoOpenAPITools:masterfrom
aplikianer:fix-swift4-699

Conversation

@aplikianer
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for #699

Updates Swift4 templates to support both OpenAPI "date-time" variants for deserialize dates from JSON.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

@aplikianer aplikianer changed the title Fix swift4 699 [Swift4] Support both OpenAPI "date-time" variants (Fix for 699) Nov 15, 2018
@wing328 wing328 added this to the 4.0.0 milestone Apr 17, 2019
@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019
@wing328 wing328 modified the milestones: 4.1.1, 4.1.2 Aug 26, 2019
@wing328 wing328 modified the milestones: 4.1.2, 4.1.3 Sep 11, 2019
@wing328 wing328 modified the milestones: 4.1.3, 4.2.0 Oct 4, 2019
@wing328 wing328 removed this from the 4.2.0 milestone Oct 30, 2019
@4brunu 4brunu mentioned this pull request Dec 25, 2019
4 tasks
@wing328
Copy link
Member

wing328 commented Jan 2, 2020

The fix is available in the newly-added swift5 generator so closing this one instead.

@wing328 wing328 closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants