Skip to content

[Java] maven plugin to clean-up output before generation#14935

Merged
wing328 merged 1 commit intomasterfrom
cleanup-output-folder
Mar 25, 2023
Merged

[Java] maven plugin to clean-up output before generation#14935
wing328 merged 1 commit intomasterfrom
cleanup-output-folder

Conversation

@borsch
Copy link
Member

@borsch borsch commented Mar 12, 2023

#14928

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05) ❤️

@borsch borsch requested a review from jimschubert as a code owner March 12, 2023 11:00
@borsch borsch added this to the 6.5.0 milestone Mar 13, 2023
@borsch borsch force-pushed the cleanup-output-folder branch from 09d339d to e3c5a63 Compare March 18, 2023 08:07
@borsch borsch requested a review from wing328 March 18, 2023 08:07
@wing328
Copy link
Member

wing328 commented Mar 18, 2023

The CI tests (maven plugin) failed. Can you please take a look when you've time?

@borsch borsch force-pushed the cleanup-output-folder branch from e3c5a63 to a594ed3 Compare March 18, 2023 15:19
@borsch
Copy link
Member Author

borsch commented Mar 18, 2023

@wing328 issue was due to this change 564939a
Now jersey2 use diamond operator here 564939a#diff-e9ec55c3c14a0cce87cfa478732f202228aa39c395d1bae2c2f9dd7ea5074175R100 which is not supported inside maven plugin samples because java 1.7 was configured there

Is there a way to trigger maven/gradle plugin build once related libraries are updated? Like in this case to trigger jersey2 sample generation with maven plugin

@wing328
Copy link
Member

wing328 commented Mar 25, 2023

Is there a way to trigger maven/gradle plugin build once related libraries are updated? Like in this case to trigger jersey2 sample generation with maven plugin

it's possible. i'll see what i can do after merging this PR.

@wing328 wing328 merged commit 18e28ab into master Mar 25, 2023
@wing328 wing328 deleted the cleanup-output-folder branch March 25, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants