Generic JSON body support in rust-server#1523
Merged
bjgill merged 2 commits intoOpenAPITools:masterfrom Dec 4, 2018
Metaswitch:generic-json-bodies
Merged
Generic JSON body support in rust-server#1523bjgill merged 2 commits intoOpenAPITools:masterfrom Metaswitch:generic-json-bodies
bjgill merged 2 commits intoOpenAPITools:masterfrom
Metaswitch:generic-json-bodies
Conversation
bjgill
approved these changes
Nov 26, 2018
Contributor
bjgill
left a comment
bjgill
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM.
I'll wait until Friday, to give other people a chance to review, before merging.
Contributor
|
Right. Let's get this merged, then. |
Member
|
@mthebridge thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Ensure that generic JSON bodies are correctly autogenerated Generates valid Rust for an arbitrary JSON response body of type `object` with no other schema.
This was referenced Jul 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Generates valid rust for an arbitrary JSON response body of type
objectwith no other schema.@frol @farcaller @bjgill