[SPRING] Generate constants for paths (#1385)#1532
Closed
adrianiacobghiula wants to merge 1 commit intoOpenAPITools:masterfrom
adrianiacobghiula:master
Closed
[SPRING] Generate constants for paths (#1385)#1532adrianiacobghiula wants to merge 1 commit intoOpenAPITools:masterfrom adrianiacobghiula:master
adrianiacobghiula wants to merge 1 commit intoOpenAPITools:masterfrom
adrianiacobghiula:master
Conversation
cognifloyd
approved these changes
Mar 14, 2019
Contributor
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
This looks like a nice addition to the Spring generator.
Contributor
|
Nice addition, I already did it it 'kind of' with using custom templates. But we've generated the paths in the same api interface. Will be this available in 4.0.0 release ? |
cbornet
reviewed
Mar 25, 2019
| package {{package}}; | ||
|
|
||
| {{#operations}} | ||
| public interface {{classname}}Route { |
Member
There was a problem hiding this comment.
Constants should not be defined in interfaces : https://rules.sonarsource.com/java/tag/bad-practice/RSPEC-1214
Member
|
What is the gain of this ? I find it easier to read URLs directly in controllers. But that may be just me... |
Member
|
Closing this as there's no update @adrianiacobghiula let us know if you still want to proceed with this PR. |
This was referenced Jul 31, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.@diyfr
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
@wing328
Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)