Closed
Conversation
meganemura
force-pushed
the
ruby-faraday
branch
2 times, most recently
from
1a8fb01 to
44685be
Compare
meganemura
force-pushed
the
ruby-faraday
branch
from
44685be to
20f548e
Compare
Member
|
@meganemura thanks for the PR. Do you need help with the implementation? Let us know. |
Contributor
|
@meganemura Are you planning to continue this work? |
Member
|
@dkliban did you have a chance to test it? If you can list out things that need improvement, we can work together on those items. |
Contributor
|
@wing328 I tried generating a client from this PR and was able to generate a client, however, the Gem spec file needs is specifying the dependencies incorrectly. I will investigate this next. I rebased this PR against the master branch without problems. Then I ran into #3335 when generating a Ruby client this time. So I think 3335 is not a language specific bug. |
Member
|
Closed via #3405 |
This was referenced Jul 31, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧under construction 🚧
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Implementation of #1422.