Skip to content

[JAVA][Server] Fixed issue #1525: Fix model class field initializations (Regression since 3.3.1)#1549

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
ccozzolino:fix_#1525
Dec 12, 2018
Merged

[JAVA][Server] Fixed issue #1525: Fix model class field initializations (Regression since 3.3.1)#1549
wing328 merged 2 commits intoOpenAPITools:masterfrom
ccozzolino:fix_#1525

Conversation

@ccozzolino
Copy link
Contributor

Fixed issue #1525. Fix model class field initializations.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes #1525. Added proper initialization of model class fields to fix regression introduced in 3.3.1

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 modified the milestones: 3.3.4, 4.0.0 Nov 30, 2018
@ccozzolino
Copy link
Contributor Author

@wing328 - can we merge?

@wing328 wing328 merged commit 95c7443 into OpenAPITools:master Dec 12, 2018
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@ccozzolino thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…nitializations (Regression since 3.3.1) (OpenAPITools#1549)

* Fixed issue OpenAPITools#1525. Adjust class field declarations with proper initializations.

* Adjusted templates to add default only when it is exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JAVA][Server] Generated model classes are missing default values

2 participants

Comments