Fix NPE in ModelUtils.isFreeFormObject()#1625
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 7, 2018
padamstx:padamstx/issue-1624
Merged
Fix NPE in ModelUtils.isFreeFormObject()#1625wing328 merged 1 commit intoOpenAPITools:masterfrom padamstx:padamstx/issue-1624
wing328 merged 1 commit intoOpenAPITools:masterfrom
padamstx:padamstx/issue-1624
Conversation
Fixes #1696 An object schema containing no properties that also has additionalProperties set to an object schema with no properties will cause ModelUtils.isFreeFormObject to throw an NPE. This PR adds additional checking to avoid the NPE.
Contributor
Author
Member
|
@padamstx thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Fixes OpenAPITools#1696 An object schema containing no properties that also has additionalProperties set to an object schema with no properties will cause ModelUtils.isFreeFormObject to throw an NPE. This PR adds additional checking to avoid the NPE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1624
An object schema containing no properties that also has additionalProperties
set to an object schema with no properties will cause
ModelUtils.isFreeFormObject to throw an NPE.
This PR adds additional checking to avoid the NPE.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
The change essentially just adds an extra check to make sure the "additionalProperties" schema's properties list is not null before calling "isEmpty()" on it.