Skip to content

[php-nextgen] Fix parent class check in ObjectSerializer#16558

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
JulianVennen:php-nextgen-enums
Sep 12, 2023
Merged

[php-nextgen] Fix parent class check in ObjectSerializer#16558
wing328 merged 1 commit intoOpenAPITools:masterfrom
JulianVennen:php-nextgen-enums

Conversation

@JulianVennen
Copy link
Contributor

In #16556 I updated the ObjectSerializer to work with the new PHP enums. Unfortunately I got a little confused and performed an instanceof check on the class string.
This PR fixes this by using is_subclass_of

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.0.1 milestone Sep 12, 2023
@wing328 wing328 merged commit cd0fde4 into OpenAPITools:master Sep 12, 2023
@wing328
Copy link
Member

wing328 commented Sep 12, 2023

@JulianVennen thanks again for the PR. When you've time, can you please PM me via Slack to discuss the php-nextgen generator?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@JulianVennen JulianVennen deleted the php-nextgen-enums branch September 12, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments