Skip to content

Add tests for python client with disallowAdditionalPropertiesIfNotPresent set to true#16690

Merged
wing328 merged 4 commits intomasterfrom
python-test3
Oct 1, 2023
Merged

Add tests for python client with disallowAdditionalPropertiesIfNotPresent set to true#16690
wing328 merged 4 commits intomasterfrom
python-test3

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Sep 30, 2023

Add tests for python client with disallowAdditionalPropertiesIfNotPresent set to true

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 Before merging this, and once #16867 has been merged (I'm not sure which one goes first), could you also add this new sample to https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-python-client-echo-api.yaml?

@wing328
Copy link
Member Author

wing328 commented Oct 1, 2023

added via 6d692ae

@wing328 wing328 marked this pull request as ready for review October 1, 2023 09:34
@wing328 wing328 requested a review from jimschubert as a code owner October 1, 2023 09:34
@wing328 wing328 merged commit 3fcf558 into master Oct 1, 2023
@wing328 wing328 deleted the python-test3 branch October 1, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants