Improve model class of ruby-client#1670
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Dec 15, 2018
Merged
Conversation
meganemura
force-pushed
the
ruby-improve-build
branch
from
592a67a to
d64060a
Compare
meganemura
force-pushed
the
ruby-improve-build
branch
from
d64060a to
b66ea1e
Compare
Member
|
@meganemura the PR looks good to me. I'll merge it over the weekend if no one has further question/feedback. Have a nice weekend! |
Contributor
Author
|
Thanks 😄 |
Member
|
@meganemura thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Add Model.build_from_hash * Use Model.build_from_hash instead of Model.new.build_from_hash * Update sample for ruby-client * Update sample for openapi3 ruby-client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
In ruby client, we use many
Model.new.build_from_hash.This change removes redundant
.new.