Skip to content

[C] map set to list, add tests#16730

Merged
wing328 merged 1 commit intomasterfrom
c-set
Oct 7, 2023
Merged

[C] map set to list, add tests#16730
wing328 merged 1 commit intomasterfrom
c-set

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Oct 5, 2023

map set to list so that the output compiles before someone has time to map set to a proper set data structure in C.

to close #16611

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@zhemant (2018/11) @ityuhui (2019/12) @michelealbano (2020/03)

@wing328 wing328 changed the title [map set to list, add tests [C] map set to list, add tests Oct 5, 2023
@wing328 wing328 added this to the 7.1.0 milestone Oct 5, 2023
@wing328 wing328 merged commit 893154d into master Oct 7, 2023
@wing328 wing328 deleted the c-set branch October 7, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][C] C compiler fails because model includes "set.h" which does not exist.

1 participant