[typescript-axios] Add Support for Operation Servers#16782
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Oct 27, 2023
Bandwidth-Sandbox:ts-axios-operation-servers
Merged
[typescript-axios] Add Support for Operation Servers#16782wing328 merged 4 commits intoOpenAPITools:masterfrom Bandwidth-Sandbox:ts-axios-operation-servers
wing328 merged 4 commits intoOpenAPITools:masterfrom
Bandwidth-Sandbox:ts-axios-operation-servers
Conversation
Member
|
Thanks for the PR. Overall it looks good to me. From what I understand, this is not a breaking change. Please correct me if I'm wrong. |
Contributor
Author
You're correct, this should be non-breaking |
6 tasks
|
Is it possible to disable this feature? |
5 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for operation level servers in the typescript-axios generator. A new object (
operationServerMap) has been added to thebase.tsfile, this object contains all server objects defined at the operation level in the openapi spec file. Inside the functional programming interface for each API, each operation now checks for a server url defined inoperationServerMapusing the newserverIndexattribute of theConfigurationclass. If a url is found, that url will be used instead of the defaultBASE_URL. This change should be non-breaking; if there is not a server defined on the operation level, the behavior will not change.serverIndexis an optional parameter on theConfigurationclass and defaults to 0.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)