[BUG][GO] Add support for all +json and +xml suffixed media types#16816
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Oct 16, 2023
Merged
[BUG][GO] Add support for all +json and +xml suffixed media types#16816wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
Member
|
thanks for the PR. what about creating a new file named api_cliet_test.go in https://github.com/OpenAPITools/openapi-generator/tree/master/samples/openapi3/client/petstore/go and add some tests for xmlCheck, jsonCheck? |
Contributor
Author
|
Thanks for pointing me in the right direction. The members had to be exported in order to test them outside of the package but that shouldn't be a problem. Does https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/go need the tests as well? |
Member
No. Eventually we will consolidate the Go petstore tests to use only OpenAPI v3 spec. Have a nice weekend |
wing328
reviewed
Oct 15, 2023
modules/openapi-generator/src/main/resources/go/client_test.mustache
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16811
I don't see tests for the generated client in the repo so I threw together these tests just to sanity-check. They passed ✅.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)