Skip to content

[Bug] [Java] Upgrade Guava version to 32.1.3#16833

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
Bhargav061197:master
Oct 17, 2023
Merged

[Bug] [Java] Upgrade Guava version to 32.1.3#16833
wing328 merged 2 commits intoOpenAPITools:masterfrom
Bhargav061197:master

Conversation

@Bhargav061197
Copy link

@Bhargav061197 Bhargav061197 commented Oct 15, 2023

to close #16832

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Bhargav061197 Bhargav061197 changed the title [Java] #16832: Upgrade Guava version to 32.0.1 [Bug] [Java] #16832: Upgrade Guava version to 32.0.1 Oct 15, 2023
@wing328
Copy link
Member

wing328 commented Oct 15, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

pom.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about updating the version to https://mvnrepository.com/artifact/com.google.guava/guava/32.1.3-jre instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, yes we can upgrade the version to 32.1.3 , build is successfull and tests as well.

@Bhargav061197
Copy link
Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thank you :), i have fixed this and commit now shows against my contribution.

@Bhargav061197 Bhargav061197 changed the title [Bug] [Java] #16832: Upgrade Guava version to 32.0.1 [Bug] [Java] #16832: Upgrade Guava version to 32.1.3 Oct 16, 2023
@wing328 wing328 changed the title [Bug] [Java] #16832: Upgrade Guava version to 32.1.3 [Bug] [Java] Upgrade Guava version to 32.1.3 Oct 17, 2023
@wing328 wing328 added this to the 7.1.0 milestone Oct 17, 2023
@wing328 wing328 merged commit 8feef52 into OpenAPITools:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] CVE-2023-2976 Guava version vulnerability high severity

3 participants