Skip to content

Update ktor client version for custom plugin support#16869

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
mtriston:update-ktor-client-version-2.3.5
Oct 23, 2023
Merged

Update ktor client version for custom plugin support#16869
wing328 merged 2 commits intoOpenAPITools:masterfrom
mtriston:update-ktor-client-version-2.3.5

Conversation

@mtriston
Copy link
Contributor

@mtriston mtriston commented Oct 19, 2023

Update ktor-client lib from 2.1.3 to 2.2.3

Issue - #16867

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mtriston mtriston force-pushed the update-ktor-client-version-2.3.5 branch from 881d888 to b23fe27 Compare October 19, 2023 13:08
@mtriston mtriston changed the title Update ktor-client version to 2.3.5 Update ktor-client version Oct 19, 2023
@mtriston
Copy link
Contributor Author

mtriston commented Oct 19, 2023

Ran into a problem when tried update version to 2.3.5
https://github.com/OpenAPITools/openapi-generator/actions/runs/6572432986/job/17857278351
Can't figure out how to fix it.

Update to 2.2.3. That's enough to add custom plugins support.

@mtriston mtriston changed the title Update ktor-client version Update ktor client version for custom plugin support Oct 19, 2023
@mtriston
Copy link
Contributor Author

@jimschubert (2017/09) @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @wing328
Hello! Have a look at this pr, please.

@wing328 wing328 merged commit f16744a into OpenAPITools:master Oct 23, 2023
@wing328
Copy link
Member

wing328 commented Oct 23, 2023

@mtriston thanks for the PR, which has been merged into the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants