Support custom headers in elm client#1736
Closed
hmac wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Conversation
42e58bb to
c3d6a8d
Compare
Author
|
Just seen this is a duplicate of #1704 - will close this for now on the assumption that that gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This change adds a new option to the Elm generator:
enableCustomHeaders. When enabled, the generated request functions will allow you to set your own headers (e.g. for authorisation). It's very similar to thebasePathoption. I would really like to make this change without introducing another option or breaking existing code, but Elm's records don't support optional fields or default values, so this is the best I could do.Very interested to hear feedback if there's a better approach here!
cc @trenneman