Skip to content

Fix: Inline models can't be generated#1768

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
ackintosh:fix-inline-model-resolver
Dec 31, 2018
Merged

Fix: Inline models can't be generated#1768
wing328 merged 5 commits intoOpenAPITools:masterfrom
ackintosh:fix-inline-model-resolver

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 28, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed that inline models couldn't be flatten when components doesn't exist in the spec.

@wing328 wing328 added this to the 4.0.0 milestone Dec 31, 2018
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 354db2f into OpenAPITools:master Dec 31, 2018
@ackintosh ackintosh deleted the fix-inline-model-resolver branch January 4, 2019 00:22
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Add a test case

* Fix that the inline models couldn't be flatten when "components" doesn't exist

* Rename yaml file

* Rename method name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments