Skip to content

[cxf] add support for Swagger2 (#3668)#17696

Closed
fizzet wants to merge 4 commits intoOpenAPITools:masterfrom
fizzet:feature/issue-3668-cxf-openapiv3
Closed

[cxf] add support for Swagger2 (#3668)#17696
fizzet wants to merge 4 commits intoOpenAPITools:masterfrom
fizzet:feature/issue-3668-cxf-openapiv3

Conversation

@fizzet
Copy link
Contributor

@fizzet fizzet commented Jan 24, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@wing328
Copy link
Member

wing328 commented Jan 31, 2024

thanks for the PR. can you please PM me via Slack for a quick chat when you've time?
https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@fizzet
Copy link
Contributor Author

fizzet commented Jan 31, 2024

Sorry, I'm not on Slack

@Harpune
Copy link

Harpune commented Mar 18, 2024

Thanks for this PR! Is there any update on the merge?

@wing328
Copy link
Member

wing328 commented Oct 23, 2024

please resolve the merge conflicts and we will try to get it merged

@fwermelskirchen
Copy link
Contributor

@wing328, unfortunately this PR is still not merged and @fizzet has no activity. Could we please merge #19954 instead?

@wing328
Copy link
Member

wing328 commented Sep 20, 2025

#19954 is just an issue (not PR)

can you (or anyone) file a new PR on top of this one with resolved merge conflicts?

@fwermelskirchen
Copy link
Contributor

reselved merge conflicts in #22010

@wing328
Copy link
Member

wing328 commented Sep 22, 2025

@fwermelskirchen thanks. i'll get it reviwed and merged asap

@wing328 wing328 mentioned this pull request Sep 24, 2025
6 tasks
@wing328
Copy link
Member

wing328 commented Sep 24, 2025

closed via #22010

@wing328 wing328 closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants