feat(rust): implement from trait on enum variants#17866
Closed
ctrlaltf24 wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
feat(rust): implement from trait on enum variants#17866ctrlaltf24 wants to merge 1 commit intoOpenAPITools:masterfrom
ctrlaltf24 wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Helpful QoL to reduce verbosity.
Before PR:
```rust
let apple_fruit = Fruit::Apple(Box::new(Apple {
seeds: 5
};
```
After PR additional option is added:
```
let apple_fruit: Fruit = Apple {
seeds: 5
};
```
DDtKey
reviewed
Feb 21, 2024
Comment on lines
+80
to
+87
| {{#oneOf}} | ||
|
|
||
| impl From<{{{.}}}> for {{classname}} { | ||
| fn from(model: {{{.}}}) -> Self { | ||
| Self::{{{.}}}(Box::new(model)) | ||
| } | ||
| } | ||
| {{/oneOf}} |
Contributor
There was a problem hiding this comment.
Note that {{#oneOf}} {{{.}}} {{/oneOf}} isn't enough here.
Even against current code - there is a case with mappedModels, but actual issue is that current implementation in master have several issues, including wrong imports.
You can take a look at #17915
I think this feature should be introduced only after the fixes
Contributor
Author
|
Sending into draft to focus rust effort on #17915 |
Contributor
Author
|
Closing PR, don't have time to work on it right now, someone else is free to pick up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful Quality of Life to reduce verbosity.
Before PR:
After PR additional option is added:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @wing328