Skip to content

[AspDotNet] Add nullable to model fields#17934

Merged
wing328 merged 1 commit intomasterfrom
features/add-nullable-to-model-fields
Feb 23, 2024
Merged

[AspDotNet] Add nullable to model fields#17934
wing328 merged 1 commit intomasterfrom
features/add-nullable-to-model-fields

Conversation

@JFCote
Copy link
Member

@JFCote JFCote commented Feb 22, 2024

The already existing nullableReferenceType added support for nullable parameters, but not for the fields inside of the models which was problematic.

With this simple change, the fields are now nullable as they should be.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@JFCote
Copy link
Member Author

JFCote commented Feb 22, 2024

@wing328 Small improvements to support nullable type better.

@wing328 wing328 merged commit a6771ad into master Feb 23, 2024
@JFCote JFCote deleted the features/add-nullable-to-model-fields branch February 23, 2024 12:08
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
oscarr-reyes pushed a commit to oscarr-reyes/openapi-generator that referenced this pull request Feb 25, 2024
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
@douglas-amici
Copy link

@JFCote / @wing328, is it intended behaviour that with nullableReferenceTypes all fields will be output as nullable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants