Fix model generation of array with items unique = true#18104
Merged
wing328 merged 6 commits intoOpenAPITools:masterfrom Mar 14, 2024
MelleD:18102_Model-generation-of-array-with-uniqueItems_is_not_working
Merged
Fix model generation of array with items unique = true#18104wing328 merged 6 commits intoOpenAPITools:masterfrom MelleD:18102_Model-generation-of-array-with-uniqueItems_is_not_working
wing328 merged 6 commits intoOpenAPITools:masterfrom
MelleD:18102_Model-generation-of-array-with-uniqueItems_is_not_working
Conversation
5 tasks
…eItems_is_not_working # Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
wing328
reviewed
Mar 14, 2024
| as.setMaxItems(schema.getMaxItems()); | ||
| as.setExtensions(schema.getExtensions()); | ||
| as.setXml(schema.getXml()); | ||
| as.setUniqueItems(schema.getUniqueItems()); |
Member
There was a problem hiding this comment.
thanks for the fix
fyi @OpenAPITools/generator-core-team
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix model generation of array with items unique = true as Java Set. Also fix the default values handling for Sets.
Fix #18102
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)