Skip to content

Fix build issue when using dotnet 8.0.300#18712

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
omer-za:patch-1
May 23, 2024
Merged

Fix build issue when using dotnet 8.0.300#18712
wing328 merged 1 commit intoOpenAPITools:masterfrom
omer-za:patch-1

Conversation

@omer-za
Copy link
Contributor

@omer-za omer-za commented May 20, 2024

dotnet/sdk#40445

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@omer-za
Copy link
Contributor Author

omer-za commented May 20, 2024

@wing328 Can you please review and help me push it forward ?

@wing328
Copy link
Member

wing328 commented May 21, 2024

thanks for the PR. i've filed #18720 based on your PR with updated samples.

all tests passed.

if no further feedback, I'll merge this PR later this week.

cc @devhl-labs

@wing328 wing328 merged commit a230588 into OpenAPITools:master May 23, 2024
@omer-za omer-za deleted the patch-1 branch May 23, 2024 07:13
@omer-za
Copy link
Contributor Author

omer-za commented May 23, 2024

Thanks @wing328 ! when is the next expected release ?

@wing328
Copy link
Member

wing328 commented May 23, 2024

https://github.com/OpenAPITools/openapi-generator/milestones

you can use customized templates (e.g. -t via CLI) for the time being

@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants