[JAVA] Fix optional collection initialized with object [fix: #18735]#18738
Closed
mosesonline wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
[JAVA] Fix optional collection initialized with object [fix: #18735]#18738mosesonline wants to merge 2 commits intoOpenAPITools:masterfrom
mosesonline wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
6 tasks
3d77ec9 to
3b1a057
Compare
check required collections are not null update samples and tests
3b1a057 to
e8c9139
Compare
540b5a4 to
40f8dee
Compare
Contributor
Author
|
The current behavior is compliant with Open API specification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7.5.0 optional field in collections where initialized with an Object (i.e. new ArrayList<>()) but before they where initialized with null. This PR fixes this by using the required-Property to skip returning null and returning a default-Value. (#18735)
I've also added a test for it.
technical committee member: @martin-mfg
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)