Skip to content

[Java][native] Fix: DateTime in deepObjects is no longer serialized correctly [fix #18742]#18743

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
marcel-huber-ptv:bugfix/18742
May 27, 2024
Merged

[Java][native] Fix: DateTime in deepObjects is no longer serialized correctly [fix #18742]#18743
wing328 merged 3 commits intoOpenAPITools:masterfrom
marcel-huber-ptv:bugfix/18742

Conversation

@marcel-huber-ptv
Copy link
Contributor

@marcel-huber-ptv marcel-huber-ptv commented May 23, 2024

Implements proposed solution from #18742. ApiClient.valueToString is used instead of String.valueOf to ensure correct formatting of OffsetDateTime objects.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented May 27, 2024

thanks for the fix. let's give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants