Skip to content

tiny simplification of typescript-nestjs api.service.mustache#18749

Merged
macjohnny merged 1 commit intomasterfrom
macjohnny-patch-1
May 23, 2024
Merged

tiny simplification of typescript-nestjs api.service.mustache#18749
macjohnny merged 1 commit intomasterfrom
macjohnny-patch-1

Conversation

@macjohnny
Copy link
Member

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@macjohnny
Copy link
Member Author

FYI @arivanandan, related to #18744

@macjohnny macjohnny merged commit 7bc2a66 into master May 23, 2024
@macjohnny macjohnny deleted the macjohnny-patch-1 branch May 23, 2024 14:53
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants