Merged
Conversation
b20c55a to
8638013
Compare
Contributor
Author
|
@wing328 Reviewers and contributors are going to like this :) Unfortunately Windows and CircleCI checks are still far >10m, however this helps with time needed for local test suite execution. |
Depending on test exec environment, this test could linger around for ~8 minutes, b/c pinging test.com will not resolve and run into seveal timeouts.
8638013 to
5a17fdc
Compare
Member
|
nice. thanks for the PR. for windows, we can improve that with another PR later. |
Contributor
Author
@wing328 i checked the actions' log, the test in question also fails quickly as expected there – however the total runtime of the windows actions is still high. Wondering how that could be optimized though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on test exec environment, this test could linger around for ~8 minutes, b/c pinging test.com will not resolve and run into several timeouts.
Brings down CI time for Linux Suite from >10m to ~4m.
Before
Connections in this test time out with
After
Connection fails immediately with
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)