[crystal-lang] Update dependencies to remedy build failure#18755
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom May 26, 2024
Merged
[crystal-lang] Update dependencies to remedy build failure#18755wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Member
|
cc @cyangle |
…conflicting library version.
a541d96 to
bb404a9
Compare
Contributor
Author
|
Thank you! I've amended the commits to show my minor contributions. |
Member
|
tested locally and the result is good. will file another PR to update the tests accordingly |
Member
|
merged follow-up PR (#18766) to update the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extremely straightforward change that bumps the version of Kemal and Crest in order to fix a build error after a
shards update. The issue experienced is a failure for the generated client library to run due to an error in the dependent library http_proxy. This library is in a unusable state in version 0.8.1 due to a function prototype mismatch with its provided argument types. For review @wing328.An OpenAPI-Generator user using the Crystal Language generator will experience a backtrace like this when using the current generator:
The root cause is the definition of time variables as Float64 in http_proxy's client.cr version 0.8.1.
This conflicts with the same library's prototype which has implied type of Time::Span instead of Float64 client.cr.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)