[crystal-lang] Resolve type check compile error in ApiError#18759
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom May 26, 2024
Merged
[crystal-lang] Resolve type check compile error in ApiError#18759wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
…n nillable type. This appears a poor implementation issue by crystal-lang, but this explicit try avoids the issue for now.
5a32437 to
9b4b189
Compare
Member
|
tested locally and the tests passed thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying a rescue'd ApiError causes a compile-time error using crystal-lang v1.12.1. The
@messageinstance variable is defined asString | Nil; however, even with a.nil?check, the variable causes a compile-time error when a further.empty?call is made.The offending line uses the
||(logical OR) operator to ensure@messageis notNil. Although this should logically ensure that further operations on@messagewere only applied to@messagewhen it is of typeString, this is not what is seen during a compilation. It is unintuitive that this is necessary as crystal-lang's logical OR operator uses left-hand associativity.This PR uses
.tryto make the.empty?call. Since Nil defines.tryand ignores it, this achieves the same functional goal.@wing328 @cyangle
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)