feat(typescript-angular): add support for Angular V18#18916
Merged
macjohnny merged 3 commits intoOpenAPITools:masterfrom Jun 14, 2024
focTZi:feat/typescript-angular/add-v18-support
Merged
feat(typescript-angular): add support for Angular V18#18916macjohnny merged 3 commits intoOpenAPITools:masterfrom focTZi:feat/typescript-angular/add-v18-support
macjohnny merged 3 commits intoOpenAPITools:masterfrom
focTZi:feat/typescript-angular/add-v18-support
Conversation
macjohnny
requested changes
Jun 13, 2024
Member
macjohnny
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Please apply the change and then we should be good to go
...nerator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java
Show resolved
Hide resolved
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add support for Angular V18
I have more or less replicated PR #17685 for angular 18. Our angular project is still very simple and my understanding of the topic is limited, so please review critically, because I may have overlooked something critical. Feel free to add any improvements, suggestions or reject as needed.
Technical committee
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)