Remove dependency scan for inputSpec (actually not required)#19084
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Jul 9, 2024
Merged
Remove dependency scan for inputSpec (actually not required)#19084wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
5a2586f to
1ab3950
Compare
7e4b286 to
c8fb37a
Compare
added test with resource on classpath with external-ref. Test with profile 'resource' was wrong as it took JAR into account, but there was no 'petstore.yaml' on classpath.
It is still possible to provide JARs as inputSpec, however the user has to provide it by hand. Providing dependencies in plugin section still allows correct inputSpec resolution on classpath.
Member
|
thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #19073.
The dependency scan introduced with #18576 is actually not required. (And I am i am sorry for the inconvenience.)
Resolution for
inputSpecworks with correct classpath setup or absolute file reference.Also it is still possible to provide an JAR
inputSpec. (Swagger only supports collapsed OpenApiSpec without external refs currently).To reproduce #19073 we need a dependency which contains an OpenApiSpec with external refs and which are not in current class path. First commit in this PR does this.
CC @wing328
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)