[GO] fix generated variable names when no discriminator is used with 'oneOf'#19183
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jul 31, 2024
Merged
[GO] fix generated variable names when no discriminator is used with 'oneOf'#19183wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
wing328
reviewed
Jul 18, 2024
| description: "No Content" | ||
| components: | ||
| schemas: | ||
| Bar: |
Member
There was a problem hiding this comment.
what about adding this new schema/model to modules/openapi-generator/src/test/resources/3_0/go/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml (the existing go test spec) instead and then regenerate the samples?
Contributor
Author
There was a problem hiding this comment.
done - ./bin/generate-samples.sh ./bin/configs/go-petstore.yaml -- -p useOneOfDiscriminatorLookup=true now reproduces the issue in model_one_of_with_complex_type.go (when the mustache changes are reverted).
- an array of strings variant should end up with the same valid name whether `useOneOfDiscriminatorLookup` is `true` or `false`
Member
|
looks good. let's give it a try thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18922. In particular,
useOneOfDiscriminatorLookupneeds to betruewhen generating to reproduce the issue; the goal is for the output to match whether it'strueorfalse.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5