feat(php-nextgen-client): add support for streaming#19192
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jul 31, 2024
escemi-tech:feat/php-nextgen-client-streaming
Merged
feat(php-nextgen-client): add support for streaming#19192wing328 merged 2 commits intoOpenAPITools:masterfrom escemi-tech:feat/php-nextgen-client-streaming
wing328 merged 2 commits intoOpenAPITools:masterfrom
escemi-tech:feat/php-nextgen-client-streaming
Conversation
Contributor
Author
|
Hi, @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon Are any of you available for a review? Thanks |
wing328
reviewed
Jul 23, 2024
...penapi-generator/src/test/java/org/openapitools/codegen/php/PhpNextgenClientCodegenTest.java
Outdated
Show resolved
Hide resolved
Member
|
can you please review the test failures? i could repeat the issue locally when testing the output |
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
Contributor
Author
|
@wing328 I've fixed you feedbacks, can you review it again please. Thanks |
Member
|
please update the samples when you've time |
…ming Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
Contributor
Author
|
@wing328 it's done (I've updated the branch with master in the same time) |
Member
|
looks good. let's give it a try. thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-nextgen client:
Add support for streaming file (https://spec.openapis.org/oas/latest.html#considerations-for-file-uploads)
Basically returning " Psr\Http\Message\StreamInterface" instead of "SplFileObject"
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch:
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jebentier
@dkarlovi
@mandrean
@jfastnacht
@ybelenko
@renepardon