Skip to content

fix(kotlin-spring): Template contains ": Serializable" which creates error on derived classes#19283

Merged
4brunu merged 1 commit intoOpenAPITools:masterfrom
deicon:fix/serializable-model-class
Aug 1, 2024
Merged

fix(kotlin-spring): Template contains ": Serializable" which creates error on derived classes#19283
4brunu merged 1 commit intoOpenAPITools:masterfrom
deicon:fix/serializable-model-class

Conversation

@deicon
Copy link
Contributor

@deicon deicon commented Aug 1, 2024

In kotlin-spring Generator, data classes have an extra ": Serializable" which breaks compilation of generated classes.

Kotlin committee members
@jimschubert
@dr4ke616
@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

Adjust dataClass.mustache and remove ": Serializable"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…rong derive clause on data classes which have a parent as well as are serializable.
@4brunu 4brunu merged commit 484b87f into OpenAPITools:master Aug 1, 2024
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants