Skip to content

[kotlin-client][jackson] Add missing @JsonEnumDefaultValue annotation to top-level enums#19380

Merged
4brunu merged 1 commit intoOpenAPITools:masterfrom
ken-tunc:kotlin-jackson-default-enum-deserialization
Aug 18, 2024
Merged

[kotlin-client][jackson] Add missing @JsonEnumDefaultValue annotation to top-level enums#19380
4brunu merged 1 commit intoOpenAPITools:masterfrom
ken-tunc:kotlin-jackson-default-enum-deserialization

Conversation

@ken-tunc
Copy link
Copy Markdown
Contributor

Support for unknown default enum values was added in #17404, but this works for only inner enums in data classes.
This PR fixes to work for top-level enums as well.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@4brunu 4brunu merged commit fd62e38 into OpenAPITools:master Aug 18, 2024
@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Aug 18, 2024

Thanks for the pull request

@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 29, 2024

@ken-tunc thanks again for the PR

when you've time, can you please PM me via Slack for a quick question if you don't mind?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants