[Java] Remove bean validation annotations on builder#19580
Merged
wing328 merged 12 commits intoOpenAPITools:masterfrom Jan 7, 2025
Merged
Conversation
Make JAX-RS spec BuilderImpl class final again
…n-validation-annotations-on-builder
…annotations-on-builder
…annotations-on-builder
…n-validation-annotations-on-builder
jpraet
changed the title
Contributor
Author
Could anyone have a look at this PR please? |
martin-mfg
suggested changes
Dec 6, 2024
Contributor
martin-mfg
left a comment
martin-mfg
left a comment
There was a problem hiding this comment.
Hi @jpraet, thanks for the PR!
Did you test locally if your changes fix the errors you reported and allow you to successfully run the generated code in JBoss EAP 7.4?
modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenProperty.java
Outdated
Show resolved
Hide resolved
…n-validation-annotations-on-builder
Contributor
Author
Yes I tested the changes locally. I will apply your suggested refactoring and test again. |
martin-mfg
approved these changes
Dec 10, 2024
Contributor
Author
|
@wing328 could this be considered for inclusion in 7.11.0? |
Member
|
@jpraet let me review and merge if no question/feedback from me have a nice weekend |
wing328
reviewed
Jan 7, 2025
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java
Outdated
Show resolved
Hide resolved
…annotations-on-builder
timon-sbr
pushed a commit
to timon-sbr/openapi-generator
that referenced
this pull request
Mar 13, 2025
) * Revert OpenAPITools#18724 Make JAX-RS spec BuilderImpl class final again * Remove bean validation annotations from builder * Also update other java generators * Introduce removeAnnotations lambda * Undo import changes to JavaHelidonClientCodegen * Add javadoc comment, examples and test for AbstractJavaCodegen.removeAnnotations()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19188 and reverts #18724.
Generated builder classes should not contain bean validation annotations.
They are unnecessary and cause problems on some Java EE servers (e.g. JBoss EAP).
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)