[cpprestsdk] Implement Enum inside Objects#19919
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Dec 4, 2024
Merged
[cpprestsdk] Implement Enum inside Objects#19919wing328 merged 5 commits intoOpenAPITools:masterfrom
wing328 merged 5 commits intoOpenAPITools:masterfrom
Conversation
… methods inside openapi-generator/modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/modelbase-header.mustache, have also be added two missing body of methods definitions
Member
|
can you please add a test or 2 in |
Member
|
let's give it a try. i will file a PR later to improve the code format a bit. thanks for the PR |
5 tasks
Contributor
Author
|
Sorry but I have been very busy these weeks. Thanks for taking care of code enhancement!
|
Member
yes please
yes please open a separate PR for easier review thanks again for your contributions |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#8937 #958(actually already closed)]
I added the support for
enumtype inside objects. They can be stand alone or inside vectors.Setof enums doesn't compile in favor of vectors(if necessary can be supported, if you think that set of enums are useful).Mapwith enums will be as before.Other then the yaml/json from the issues I used:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd