[Rust-Axum] Dynamically set the types of integer literals#20133
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Nov 25, 2024
Merged
Conversation
Contributor
Author
|
Unsure if this is a breaking change. The default floating point literal is f64, and this makes some of the existing floating point literals become f32, which can change the accuracy of some mathematical operations, but unsure if PartialOrd is one of them |
Member
|
thanks for the PR cc @linxGnu |
linxGnu
reviewed
Nov 20, 2024
modules/openapi-generator/src/main/resources/rust-axum/models.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/rust-axum/models.mustache
Outdated
Show resolved
Hide resolved
linxGnu
suggested changes
Nov 20, 2024
...rver/petstore/rust-axum/output/petstore-with-fake-endpoints-models-for-testing/src/models.rs
Show resolved
Hide resolved
7 tasks
Member
|
if no further feedback, i'll merge this PR later this week |
Contributor
|
Thank you @wing328 The PR is LGTM. Please go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the literals generated in the validators to literals that will fit the adequate types, this is necessary as literals default to i32 and values that don't fit it need its type to be specified explicitly.
This is partially related to #19291, but it does not fully fix it.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)